[4.4] refactor: a single point of sending the Response. #7519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the CodeIgniter class code so that all successful responses, except those caused by exceptions, are sent from one place.
CodeIgniter::handleRequest()
method now always returns a Response.CodeIgniter::handleRequest()
method. Because these methods generate a Response and are actually part of the request processing.Events::trigger('pre_system')
moved to methodCodeIgniter::handleRequest()
and is now on the same "level" asEvents::trigger('post_system')
CodeIgniter::$returnResponse
property has been deprecated as it is no longer used.Checklist: