New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unneeded code in IncomingRequest #7525

Merged

samsonasik merged 1 commit into codeigniter4:develop from kenjis:refactor-IncomingRequest-getLocale

May 30, 2023

Member

kenjis commented May 26, 2023

Description
$this->locale is set in the detectLocale() method called in the constructor.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide


          refactor: remove unneeded code

a4de3e7

$this->locale is set in the detectLocale() method called in the constructor.

kenjis added the refactor label

michalsn approved these changes

View reviewed changes

samsonasik approved these changes

View reviewed changes

samsonasik merged commit 167042a into codeigniter4:develop

Member

samsonasik commented May 30, 2023

Thank you @kenjis

kenjis deleted the refactor-IncomingRequest-getLocale branch

June 1, 2023 08:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels