Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Auto Routing Improved] feature testing may not find controller/method #7543

Merged
merged 9 commits into from
Jun 13, 2023
Merged

fix: [Auto Routing Improved] feature testing may not find controller/method #7543

merged 9 commits into from
Jun 13, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 6, 2023 •
edited
Loading

Description
See https://forum.codeigniter.com/showthread.php?tid=87818

  • fix AutoRouterInterface::getRoute()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft June 6, 2023 04:07
@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Jun 6, 2023
@kenjis kenjis changed the title fix: feature testing with auto routing improved fix: [Auto Routing Improved] feature testing may not find controller/method Jun 6, 2023
@kenjis kenjis force-pushed the fix-feature-testing-with-autoroute branch from a7d37df to 8f8851c Compare June 6, 2023 04:42
@kenjis kenjis marked this pull request as ready for review June 6, 2023 05:08
@kenjis kenjis force-pushed the fix-feature-testing-with-autoroute branch 2 times, most recently from e1ab0bf to 6fa296b Compare June 7, 2023 23:22
@kenjis
Copy link
Member Author

kenjis commented Jun 7, 2023

All checks passed!

@kenjis kenjis added the stale Pull requests with conflicts label Jun 9, 2023
@kenjis kenjis force-pushed the fix-feature-testing-with-autoroute branch from 6fa296b to f11fa33 Compare June 10, 2023 08:23
@kenjis kenjis removed the stale Pull requests with conflicts label Jun 10, 2023
@kenjis
Copy link
Member Author

kenjis commented Jun 10, 2023

Can someone please review this?

@kenjis kenjis requested a review from samsonasik June 13, 2023 00:16
@kenjis kenjis force-pushed the fix-feature-testing-with-autoroute branch from 5239aa7 to f22139b Compare June 13, 2023 22:31
@kenjis kenjis merged commit c87169d into codeigniter4:develop Jun 13, 2023
@kenjis kenjis deleted the fix-feature-testing-with-autoroute branch June 13, 2023 23:21
kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Jun 13, 2023
@kenjis
fix: merge conflicts
485da03 
codeigniter4#7543
This was referenced Jun 13, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @samsonasik