Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHPStan from pre-commit hook #7618

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Remove PHPStan from pre-commit hook #7618

merged 1 commit into from
Jun 27, 2023

Conversation

lonnieezell
Copy link
Member

This removes PHPstan from our precommit hook. While that was well intentioned, I believe from discussions we've had that most of the team actually finds that more trouble than it is worth. I believe it causes a choke point for potential contributors who get stuck trying to pass that and never actually submit anywhere. With it gone, they can submit and open up a discussions about the code much easier.

At one point discussions mentioned removing the entire pre-commit hook, but I find value in the linting and auto-fixing of style issues where it can, and believe that stan was the biggest pain point in the process.

@lonnieezell lonnieezell added enhancement PRs that improve existing functionalities 4.4 labels Jun 26, 2023
@kenjis
Copy link
Member

kenjis commented Jun 26, 2023

If we accept this, why don't we go with develop?

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, it became my ritual after cloning the repo to remove the pre-commit hook. Although I am still able to run all commands separately, the hook never worked for me.

@lonnieezell lonnieezell changed the base branch from 4.4 to develop June 27, 2023 04:16
@lonnieezell lonnieezell removed the 4.4 label Jun 27, 2023
@lonnieezell
Copy link
Member Author

Rebased onto develop branch.

@kenjis kenjis merged commit 1f09de8 into develop Jun 27, 2023
@kenjis kenjis deleted the remove-precommit-hook branch June 27, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants