Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Config\App Security items #7630

Merged
merged 12 commits into from
Jun 29, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 27, 2023

Description

  • remove CSRF config items in Config\App
  • [BC] change Security constructor param from Config\App to Config\Security

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft June 27, 2023 06:33
@kenjis kenjis added 4.4 breaking change Pull requests that may break existing functionalities labels Jun 27, 2023
@kenjis kenjis force-pushed the remove-config-app-CSRF-items-4.4 branch 3 times, most recently from 9468915 to 1c7d51c Compare June 27, 2023 07:28
@kenjis kenjis marked this pull request as ready for review June 27, 2023 08:23
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, but massive change.

Not sure how many people extend the Security class (probably something around 0) but having config variables in $this->config will definitely break some things for those cases.

Anyway, I'm a bit baffled about this change with setting config items to the $this->config and depreciations.

system/Config/Services.php Outdated Show resolved Hide resolved
system/Security/Security.php Show resolved Hide resolved
system/Security/Security.php Show resolved Hide resolved
@kenjis kenjis force-pushed the remove-config-app-CSRF-items-4.4 branch from 889445f to 2868f5c Compare June 28, 2023 23:03
@kenjis kenjis force-pushed the remove-config-app-CSRF-items-4.4 branch from 27503a6 to 9df83ad Compare June 29, 2023 10:40
@kenjis kenjis force-pushed the remove-config-app-CSRF-items-4.4 branch from 9df83ad to 24e9cad Compare June 29, 2023 10:41
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@kenjis kenjis merged commit d9c7f06 into codeigniter4:4.4 Jun 29, 2023
@kenjis kenjis deleted the remove-config-app-CSRF-items-4.4 branch June 29, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 breaking change Pull requests that may break existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants