Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: number_to_roman() param type #7640

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 29, 2023

Description

  • fix param type for $num
<?php
declare(strict_types=1);
namespace App\Controllers;
class Home extends BaseController
{
    public function index()
    {
        helper('number');
        echo number_to_roman(23);
    }
}

The above code causes the type error:

TypeError
number_to_roman(): Argument #1 ($num) must be of type string, int given

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 29, 2023
@kenjis kenjis merged commit 46e1ab1 into codeigniter4:develop Jun 29, 2023
@kenjis kenjis deleted the fix-number_to_roman branch June 29, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants