Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove uneeded if in Commands\Utilities\Routes #7661

Merged
merged 1 commit into from
Jul 6, 2023
Merged

refactor: remove uneeded if in Commands\Utilities\Routes #7661

merged 1 commit into from
Jul 6, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 6, 2023

Description
Follow-up #7653

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jul 6, 2023
@kenjis kenjis mentioned this pull request Jul 6, 2023
Merged
2 tasks
@samsonasik
Copy link
Member

Let's give it a try, thank you @kenjis

@samsonasik samsonasik merged commit 49c4772 into codeigniter4:4.4 Jul 6, 2023
@kenjis kenjis deleted the refactor-Commands-Utilities-Routes branch July 6, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik