refactor: [Cache] simplify code of FileHandler::getItem()
#7667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
changed the title
FileHandler::getItem()FileHandler::getItem()
kenjis
reviewed
Jul 6, 2023
paulbalandan
force-pushed
the
refactor-file-handler-cache
branch
from
d13b6e7
to
e83b5bd
Compare
kenjis
reviewed
Jul 7, 2023
paulbalandan
force-pushed
the
refactor-file-handler-cache
branch
from
e83b5bd
to
093dc6e
Compare
kenjis
reviewed
Jul 7, 2023
paulbalandan
force-pushed
the
refactor-file-handler-cache
branch
from
093dc6e
to
78ff86f
Compare
michalsn
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure safety nets to
$data['ttl']and$data['time']Checklist: