Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove instantiation of Response in Services::exceptions() #7670

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 7, 2023

Description
In 4.3 or before, Request and Response objects are created in Services::exceptions() in CodeIgniter::initialize(). It is too early, and it created bug #7668.

In 4.4 branch, we have already removed instantiation of Request in Services::exceptions().
This PR removes the instantiation of Response, and both Request and Response objects will be created in CodeIgniter::run().

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities 4.4 labels Jul 7, 2023
@kenjis kenjis added the stale Pull requests with conflicts label Jul 29, 2023
@kenjis kenjis removed the stale Pull requests with conflicts label Jul 29, 2023
@kenjis
Copy link
Member Author

kenjis commented Jul 29, 2023

Rebased to resolve conflict.

@kenjis
Copy link
Member Author

kenjis commented Aug 2, 2023

Rebased to resolve conflict.

This is a simple PR. Can someone review?

@kenjis kenjis merged commit b496f46 into codeigniter4:4.4 Aug 3, 2023
52 checks passed
@kenjis kenjis deleted the fix-Services-exceptions branch August 3, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants