fix: auto routing legacy and $route->add()

[kenjis]

Description
See https://forum.codeigniter.com/showthread.php?tid=86977

There is a bug:

• When you enable Auto Routing Legacy, if you $route->add(), the controller's other methods are inaccessible from the web browser.

How to Test

--- a/app/Config/Routes.php
+++ b/app/Config/Routes.php
@@ -19,7 +19,7 @@ $routes->set404Override();
 // where controller filters or CSRF protection are bypassed.
 // If you don't want to define all routes, please use the Auto Routing (Improved).
 // Set `$autoRoutesImproved` to true in `app/Config/Feature.php` and set the following to true.
-// $routes->setAutoRoute(false);
+$routes->setAutoRoute(true);
 
 /*
  * --------------------------------------------------------------------
@@ -31,6 +31,8 @@ $routes->set404Override();
 // route since we don't have to scan directories.
 $routes->get('/', 'Home::index');
 
+$routes->add('instructor/login', 'Instructor::login');
+
 /*
  * --------------------------------------------------------------------
  * Additional Routing

<?php

namespace App\Controllers;

class Instructor extends BaseController
{
    public function login()
    {
        return __METHOD__;
    }

    public function logout()
    {
        return __METHOD__;
    }
}

Navigate to:

• http://localhost:8080/instructor/login
• http://localhost:8080/instructor/logout

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

I restored the logic from v4.1.9:

CodeIgniter4/system/Router/Router.php

Lines 492 to 513 in 202f41a

	if ($this->collection->getHTTPVerb() !== 'cli') {
	$controller = '\\' . $defaultNamespace;
	$controller .= $this->directory ? str_replace('/', '\\', $this->directory) : '';
	$controller .= $controllerName;
	$controller = strtolower($controller);
	$methodName = strtolower($this->methodName());
	foreach ($this->collection->getRoutes('cli') as $route) {
	if (is_string($route)) {
	$route = strtolower($route);
	if (strpos($route, $controller . '::' . $methodName) === 0) {
	throw new PageNotFoundException();
	}
	if ($route === $controller) {
	throw new PageNotFoundException();
	}
	}
	}
	}

[MGatner]

One naming comment, I'm fine either way.

[TimexPeachtree]

Awesome looking forward ⏩ to 4.3.7