Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Model] setValidationRule() cannot use with ruleGroup #7691

Merged
merged 2 commits into from
Jul 16, 2023
Merged

fix: [Model] setValidationRule() cannot use with ruleGroup #7691

merged 2 commits into from
Jul 16, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 10, 2023 •
edited
Loading

Description
Fixes #7689

  • fix setValidationRule() cannot use with ruleGroup
  • fix cannot set custom error messages with Config\Validation::$ruleGroup_errors

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Jul 10, 2023
@kenjis kenjis changed the title fix: setValidationRule() cannot use with rulesGroup fix: [Model] setValidationRule() cannot use with rulesGroup Jul 10, 2023
@kenjis kenjis changed the title fix: [Model] setValidationRule() cannot use with rulesGroup fix: [Model] setValidationRule() cannot use with ruleGroup Jul 10, 2023
@kenjis kenjis mentioned this pull request Jul 10, 2023
Closed
MGatner
MGatner approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you just write all these tests? Very nice!

@kenjis kenjis merged commit 70eade0 into codeigniter4:develop Jul 16, 2023
51 checks passed
@kenjis kenjis deleted the fix-model-validation branch July 16, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [Model] setValidationRule() cannot use with ruleGroup
2 participants
@kenjis @MGatner