Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number comparison in number_to_amount() in number_helper.php #7701

Merged
merged 4 commits into from
Jul 16, 2023

Conversation

sba
Copy link
Contributor

@sba sba commented Jul 13, 2023

Description
replaces #7648

1000 gives 1 thousand and not 1000
1000000 gives 1 million and not 1000 thousand
and so on...

And it compares now the same way like the function number_to_size above

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 13, 2023
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Optional nullable parameter in PHPDoc
@kenjis kenjis merged commit c9c82b2 into codeigniter4:develop Jul 16, 2023
51 checks passed
@sba sba deleted the number_to_amount branch July 17, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants