Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trimming logic of Autoloader::loadClass() #7763

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Remove trimming logic of Autoloader::loadClass() #7763

merged 3 commits into from
Aug 4, 2023

Conversation

paulbalandan
Copy link
Member

Description
Follows #7747

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Aug 2, 2023
MGatner
MGatner approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that this is a wake-up call if some dev was relying on this behavior 😂

@kenjis kenjis merged commit 9151860 into codeigniter4:4.4 Aug 4, 2023
52 checks passed
@paulbalandan paulbalandan deleted the autoloader-loadclass branch August 4, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @MGatner