fix: Model inserts cast $primaryKey value when using Entity #7806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
the
bug
kenjis
force-pushed
the
fix-model-cast-pk
branch
from
6980fad
to
e32feba
Compare
kenjis
force-pushed
the
fix-model-cast-pk
branch
from
e32feba
to
5eef075
Compare
MGatner
requested changes
Aug 12, 2023
`method_exists($data, 'cast')` is too loose, and not good.
kenjis
force-pushed
the
fix-model-cast-pk
branch
from
5eef075
to
d82a9bb
Compare
MGatner
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7797
Checklist: