Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set_checkbox() checks unchecked checkbox #7818

Merged
merged 2 commits into from
Aug 22, 2023
Merged

fix: set_checkbox() checks unchecked checkbox #7818

merged 2 commits into from
Aug 22, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 14, 2023 •
edited
Loading

Description
Fixes #7814

set_checkbox() with default true checks unchecked checkbox when redirected back with input.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 14, 2023
This was referenced Aug 14, 2023
Closed
Closed
datamweb
datamweb approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis
test: add test for set_checkbox()
571b05b
@kenjis
fix: set_checkbox() incorrect checking
f2f7dcf 
set_checkbox() with default true checks unchecked checkbox
when redirected back with input.
MGatner
MGatner approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took me a minute to figure this out but now it looks good.

@MGatner
Copy link
Member

MGatner commented Aug 20, 2023

Hoping to hear from @WrestlingPotato

@kenjis kenjis merged commit 411a9bb into codeigniter4:develop Aug 22, 2023
52 checks passed
@kenjis kenjis deleted the fix-set_checkbox branch August 22, 2023 00:46
@WrestlingPotato
Copy link

The fix works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: For set_checkbox, when default is true the checkbox will become checked when redirected back with input.
4 participants
@kenjis @MGatner @WrestlingPotato @datamweb