Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FeatureTest may cause risky tests #7867

Merged
merged 3 commits into from
Sep 4, 2023
Merged

fix: FeatureTest may cause risky tests #7867

merged 3 commits into from
Sep 4, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 27, 2023

Description
See codeigniter4/shield#802

1) Tests\Authentication\Filters\PermissionFilterTest::testFilterNotAuthorized
Test code or tested code did not (only) close its own output buffers

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.4 labels Aug 27, 2023
@kenjis kenjis mentioned this pull request Aug 27, 2023
Closed
@kenjis kenjis mentioned this pull request Aug 29, 2023
Merged
9 tasks
@kenjis kenjis merged commit 5d40f69 into codeigniter4:develop Sep 4, 2023
51 checks passed
@kenjis kenjis deleted the fix-feature-test-buffering branch September 4, 2023 02:29
@kenjis
Copy link
Member Author

kenjis commented Sep 4, 2023

@datamweb Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
4.4 bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @datamweb