Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DebugBar] make CSS rotate class less broad #7882

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix: [DebugBar] make CSS rotate class less broad #7882

merged 1 commit into from
Sep 4, 2023

Conversation

sanchawebo
Copy link
Contributor

@sanchawebo sanchawebo commented Aug 30, 2023 •
edited
Loading

Description
Make debugbar's .rotate-class less broad.
Fixes #7875

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.4 labels Aug 30, 2023
@kenjis kenjis changed the title [DebugBar] make rotate class less broad fix: [DebugBar] make rotate class less broad Aug 30, 2023
kenjis
kenjis approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 398e44b into codeigniter4:develop Sep 4, 2023
1 check passed
@kenjis
Copy link
Member

kenjis commented Sep 4, 2023

@sanchawebo Thank you!

@kenjis kenjis changed the title fix: [DebugBar] make rotate class less broad fix: [DebugBar] make CSS rotate class less broad Sep 4, 2023
@sanchawebo sanchawebo deleted the rotateFix branch September 5, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@lonnieezell lonnieezell Awaiting requested review from lonnieezell

Assignees
No one assigned
Labels
4.4 bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [DebugBar] Rotation applied outside of toolbar
2 participants
@sanchawebo @kenjis