Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add types to View $filters and $plugins #7885

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: add types to View $filters and $plugins #7885

merged 1 commit into from
Sep 7, 2023

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Aug 31, 2023 •
edited by kenjis
Loading

Description
See #7731

References:

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan force-pushed the phpstan-view-types branch 2 times, most recently from 5174ed7 to f184d83 Compare August 31, 2023 06:53
kenjis
kenjis approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a little research, but could not find a way to eliminate the Psalm errors.

@kenjis kenjis merged commit 93670c5 into codeigniter4:develop Sep 7, 2023
51 checks passed
@paulbalandan paulbalandan deleted the phpstan-view-types branch September 8, 2023 01:06
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @kenjis