Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FeatureTest fails when forceGlobalSecureRequests is true #7890

Merged
merged 2 commits into from
Sep 4, 2023
Merged

fix: FeatureTest fails when forceGlobalSecureRequests is true #7890

merged 2 commits into from
Sep 4, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 2, 2023 •
edited
Loading

Description

  • fix bug that HTTP tests fail (do redirect) when forceGlobalSecureRequests is true

See codeigniter4projects/website#393 (review)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.4 labels Sep 2, 2023
This was referenced Sep 2, 2023
Merged
Merged
@kenjis kenjis changed the title Fix test force global secure requests fix: HTTP tests fail when forceGlobalSecureRequests is true Sep 2, 2023
@kenjis kenjis changed the title fix: HTTP tests fail when forceGlobalSecureRequests is true fix: FeatureTest fails when forceGlobalSecureRequests is true Sep 3, 2023
@kenjis kenjis added the help wanted More help is needed for the proper resolution of an issue or pull request label Sep 4, 2023
@kenjis
Copy link
Member Author

kenjis commented Sep 4, 2023

Can someone please review this?
Once this is merged, I would like to release v4.4.1.

@MGatner
Copy link
Member

MGatner commented Sep 4, 2023

LGTM

@kenjis kenjis merged commit daa8811 into codeigniter4:develop Sep 4, 2023
51 checks passed
@kenjis kenjis deleted the fix-test-forceGlobalSecureRequests branch September 4, 2023 20:35
@kenjis
Copy link
Member Author

kenjis commented Sep 4, 2023

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@datamweb datamweb datamweb approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.4 bug Verified issues on the current code behavior or pull requests that will fix them help wanted More help is needed for the proper resolution of an issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @MGatner @samsonasik @datamweb