-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove $_SESSION from methods and functions #7982
refactor: remove $_SESSION from methods and functions #7982
Conversation
a054a4a
to
223d5fe
Compare
d9c23cc
to
e1e8c86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an improvement.
Thank you.
@pjsde We do not include merge commits in PR branches. |
Co-authored-by: Mostafa Khudair <59371810+mostafakhudair@users.noreply.github.com>
2b4ef45
to
b5d123a
Compare
@pjsde Thank you! Glad you are able to use |
Functions and methods should not directly call the
$_SESSION
array but use thesession()
helper to obtain their contents from theServices::Session
library.This avoids the need to override code if someone needs to organize the
$_SESSION
array in another way.Checklist: