Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect return type for Model::objectToRawArray() #7986

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 27, 2023

Description

  • fix incorrect return types

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities docs needed Pull requests needing documentation write-ups and/or revisions. 4.5 labels Sep 27, 2023
@kenjis kenjis changed the title fix: incorrect return types for Model::objectToRawArray() fix: incorrect return type for Model::objectToRawArray() Sep 27, 2023
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Sep 27, 2023
system/BaseModel.php Outdated Show resolved Hide resolved
system/BaseModel.php Outdated Show resolved Hide resolved
system/Model.php Outdated Show resolved Hide resolved
@kenjis kenjis force-pushed the fix-Model-objectToRawArray-return-type branch from 35d1531 to 199f70c Compare September 27, 2023 01:58
@kenjis kenjis force-pushed the fix-Model-objectToRawArray-return-type branch from b9de0fa to 952aabd Compare September 28, 2023 06:39
@kenjis
Copy link
Member Author

kenjis commented Sep 28, 2023

Rebased to resolve conflicts.

@kenjis kenjis requested a review from MGatner September 28, 2023 06:40
Comment on lines +786 to 787
* @return array Array with raw values.
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @return array Array with raw values.
*

Also here.

Comment on lines +1681 to 1682
* @return array Array with raw values.
*
Copy link
Contributor

@mostafakhudair mostafakhudair Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @return array Array with raw values.
*

I think the description here is not necessary, since the method has a specific return type.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent of the comment is to indicate that the values are raw values.
However, I doubt that most people correctly understand what raw values are.

@kenjis kenjis merged commit d40c071 into codeigniter4:4.5 Sep 30, 2023
55 checks passed
@kenjis kenjis deleted the fix-Model-objectToRawArray-return-type branch September 30, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants