Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rely on $config property in ViewDecoratorTrait #8021

Merged
merged 3 commits into from
Dec 26, 2023
Merged

refactor: rely on $config property in ViewDecoratorTrait #8021

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67f8876
refactor: ViewDecoratorTrait
mostafakhudair Oct 9, 2023
753fe0e
Update system/View/ViewDecoratorTrait.php
mostafakhudair Dec 13, 2023
73bf083
Update ViewDecoratorTrait.php
mostafakhudair Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions system/View/ViewDecoratorTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
namespace CodeIgniter\View;

use CodeIgniter\View\Exceptions\ViewException;
use Config\View as ViewConfig;
mostafakhudair marked this conversation as resolved.
Show resolved Hide resolved

trait ViewDecoratorTrait
{
Expand All @@ -22,9 +21,7 @@ trait ViewDecoratorTrait
*/
protected function decorateOutput(string $html): string
{
$decorators = \config(ViewConfig::class)->decorators;

foreach ($decorators as $decorator) {
foreach ($this->config->decorators as $decorator) {
mostafakhudair marked this conversation as resolved.
Show resolved Hide resolved
if (! is_subclass_of($decorator, ViewDecoratorInterface::class)) {
throw ViewException::forInvalidDecorator($decorator);
}
Expand Down
Loading