Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: file sort order in Files DebugBar #8048

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: file sort order in Files DebugBar #8048

merged 1 commit into from
Oct 18, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 16, 2023

Description
Sort by full path.

Before:
Screenshot 2023-10-16 18 27 44

After:
Screenshot 2023-10-16 18 27 26

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
fix: file sort order
87ea6a9 
Sort by full path.
@neznaika0
Copy link
Contributor

Not bad

datamweb
datamweb reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I wanted to raise this issue in the forum. Sort by package name to add CI4.

MGatner
MGatner approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like.

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 18, 2023
@kenjis kenjis merged commit afe3cb2 into codeigniter4:develop Oct 18, 2023
65 checks passed
@kenjis kenjis deleted the fix-Files-Collector-sort branch October 18, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb left review comments

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @neznaika0 @datamweb @MGatner