refactor: update PHPUnit to 10 #8069

kenjis · 2023-10-20T23:57:09Z

Important

This PR will be merged just prior to the release of v4.5.0.

Description
PHPUnit requires PHP 8.1 or later.
https://packagist.org/packages/phpunit/phpunit#10.4.1

https://phpunit.de/announcements/phpunit-10.html

TODO

update nexusphp/tachycardia
fix errors on PHP 8.3

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis · 2023-10-20T23:59:42Z

@paulbalandan Any plan to release nexusphp/tachycardia that are compatible with PHPUnit10?

paulbalandan · 2023-10-21T00:01:43Z

Is it ready but lacking integration tests. I'll try to finish this weekend. Thanks for reminding me.

kenjis · 2023-10-21T00:06:18Z

There was 1 PHPUnit test runner warning:

1) Class CodeIgniter\Cache\Handlers\AbstractHandlerTest declared in /home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cache/Handlers/AbstractHandlerTest.php is abstract

--

There was 1 PHPUnit test runner deprecation:

1) Your XML configuration validates against a deprecated schema. Migrate your XML configuration using "--migrate-configuration"!

--

6 tests triggered 6 PHPUnit deprecations:

1) CodeIgniter\AutoReview\FrameworkCodeTest::testEachTestClassHasCorrectGroupAnnotation
Data Provider method CodeIgniter\AutoReview\FrameworkCodeTest::provideEachTestClassHasCorrectGroupAnnotation() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/AutoReview/FrameworkCodeTest.php:46

2) CodeIgniter\HTTP\SiteURITest::testConstructor
Data Provider method CodeIgniter\HTTP\SiteURITest::provideConstructor() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/HTTP/SiteURITest.php:32

3) CodeIgniter\Validation\CreditCardRulesTest::testValidCCNumber
Data Provider method CodeIgniter\Validation\CreditCardRulesTest::provideValidCCNumber() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/CreditCardRulesTest.php:54

4) CodeIgniter\Validation\StrictRules\CreditCardRulesTest::testValidCCNumber
Data Provider method CodeIgniter\Validation\StrictRules\CreditCardRulesTest::provideValidCCNumber() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/StrictRules/CreditCardRulesTest.php:55

5) CodeIgniter\Validation\StrictRules\ValidationTest::testSetRuleRulesFormat
Data Provider method CodeIgniter\Validation\StrictRules\ValidationTest::provideSetRuleRulesFormat() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/ValidationTest.php:193

6) CodeIgniter\Validation\ValidationTest::testSetRuleRulesFormat
Data Provider method CodeIgniter\Validation\ValidationTest::provideSetRuleRulesFormat() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/ValidationTest.php:193

WARNINGS!
Tests: 300, Assertions: 905, Warnings: 1, Deprecations: 7.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/6593809502/job/17916840733?pr=8069

kenjis · 2023-10-21T00:07:33Z

There was 1 PHPUnit test runner warning:

1) Class CodeIgniter\Cache\Handlers\AbstractHandlerTest declared in /home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cache/Handlers/AbstractHandlerTest.php is abstract

--

There was 1 PHPUnit test runner deprecation:

1) Your XML configuration validates against a deprecated schema. Migrate your XML configuration using "--migrate-configuration"!

--

There were 41 errors:

1) CodeIgniter\Autoloader\AutoloaderTest::testLoadHelpers
Test was run in child process and ended unexpectedly

2) CodeIgniter\CodeIgniterTest::testRunEmptyDefaultRoute
Test was run in child process and ended unexpectedly

3) CodeIgniter\CodeIgniterTest::testOutputBufferingControl
Test was run in child process and ended unexpectedly

4) CodeIgniter\CodeIgniterTest::testRunEmptyDefaultRouteReturnResponse
Test was run in child process and ended unexpectedly

5) CodeIgniter\CodeIgniterTest::testRunClosureRoute
Test was run in child process and ended unexpectedly

6) CodeIgniter\CodeIgniterTest::testRun404Override
Test was run in child process and ended unexpectedly

7) CodeIgniter\CodeIgniterTest::testRun404OverrideControllerReturnsResponse
Test was run in child process and ended unexpectedly

8) CodeIgniter\CodeIgniterTest::testRun404OverrideReturnResponse
Test was run in child process and ended unexpectedly

9) CodeIgniter\CodeIgniterTest::testRun404OverrideByClosure
Test was run in child process and ended unexpectedly

1) CodeIgniter\Validation\StrictRules\ValidationTest::testPlaceholderReplacementTestFails
Failed asserting that exception message 'Failed asserting that 'filter[{id}]' [ASCII](length: 12) does not contain "{id}" [ASCII](length: 4).' contains 'Failed asserting that 'filter[{id}]' does not contain "{id}".'.

2) CodeIgniter\Validation\ValidationTest::testPlaceholderReplacementTestFails
Failed asserting that exception message 'Failed asserting that 'filter[{id}]' [ASCII](length: 12) does not contain "{id}" [ASCII](length: 4).' contains 'Failed asserting that 'filter[{id}]' does not contain "{id}".'.

--

6 tests triggered 6 PHPUnit deprecations:

1) CodeIgniter\AutoReview\FrameworkCodeTest::testEachTestClassHasCorrectGroupAnnotation
Data Provider method CodeIgniter\AutoReview\FrameworkCodeTest::provideEachTestClassHasCorrectGroupAnnotation() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/AutoReview/FrameworkCodeTest.php:46

2) CodeIgniter\HTTP\SiteURITest::testConstructor
Data Provider method CodeIgniter\HTTP\SiteURITest::provideConstructor() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/HTTP/SiteURITest.php:32

3) CodeIgniter\Validation\CreditCardRulesTest::testValidCCNumber
Data Provider method CodeIgniter\Validation\CreditCardRulesTest::provideValidCCNumber() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/CreditCardRulesTest.php:54

4) CodeIgniter\Validation\StrictRules\CreditCardRulesTest::testValidCCNumber
Data Provider method CodeIgniter\Validation\StrictRules\CreditCardRulesTest::provideValidCCNumber() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/StrictRules/CreditCardRulesTest.php:55

5) CodeIgniter\Validation\StrictRules\ValidationTest::testSetRuleRulesFormat
Data Provider method CodeIgniter\Validation\StrictRules\ValidationTest::provideSetRuleRulesFormat() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/ValidationTest.php:193

6) CodeIgniter\Validation\ValidationTest::testSetRuleRulesFormat
Data Provider method CodeIgniter\Validation\ValidationTest::provideSetRuleRulesFormat() is not static

/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Validation/ValidationTest.php:193

ERRORS!
Tests: 5017, Assertions: 8400, Errors: 41, Failures: 2, Warnings: 1, Deprecations: 7, Skipped: 1.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/6593809497/job/17916881103?pr=8069

paulbalandan · 2023-10-21T00:24:54Z

The first warning is easy. Just change the name to AbstractHandlerTestCase. Abstract tests need to be suffixed with TestCase.

For the static issues, just run the rule php_unit_data_provider_static for php-cs-fixer

kenjis · 2023-10-21T01:45:57Z

Unfortunately php-cs-fixer was not able to refactor the dataProviders because of $this.

paulbalandan · 2023-10-21T01:50:17Z

Ah yes. The rule is risky because of uses of $this. Those cases should be modified to use static properties/methods.

kenjis · 2023-10-21T02:33:28Z

Why does this test fail?

$ vendor/bin/phpunit tests/system/Validation/StrictRules/ValidationTest.php 
PHPUnit 10.4.1 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.24
Configuration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml

.................................................................................................... 100 / 121 ( 82%)
...........F.........                                                                                121 / 121 (100%)

Time: 00:00.930, Memory: 16.00 MB

...


--

There was 1 failure:

1) CodeIgniter\Validation\StrictRules\ValidationTest::testPlaceholderReplacementTestFails
Failed asserting that exception message 'Failed asserting that 'filter[{id}]' [ASCII](length: 12) does not contain "{id}" [ASCII](length: 4).' contains 'Failed asserting that 'filter[{id}]' does not contain "{id}".'.

FAILURES!
Tests: 121, Assertions: 173, Failures: 1, Warnings: 1.

kenjis · 2023-10-21T02:42:36Z

I got the reason. The error message of PHPUnit has been changed.

MGatner

We will want to update DevKit as well - not sure when the appropriate time to do that is though, maybe when we actually drop 8.0? I know @paulbalandan is working on Tachycardia comparability - that would be great to include.

Edit: oops! I missed the existing conversation. All good.

paulbalandan · 2023-10-26T02:12:48Z

nexusphp/tachycardia v2.0 is out

kenjis · 2023-10-27T06:39:16Z

I don't know why, but only in PHP 8.3, the NoTestCaseObjectOnCallStackException occurs.

$ vendor/bin/phpunit tests/system/Autoloader/AutoloaderTest.php 
PHPUnit 10.4.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.0-dev
Configuration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml

..........................E                                                                             27 / 27 (100%)

Time: 00:00.486, Memory: 16.00 MB

There was 1 error:

1) CodeIgniter\Autoloader\AutoloaderTest::testLoadHelpers
PHPUnit\Framework\Exception: PHP Fatal error:  Uncaught CodeIgniter\Format\Exceptions\FormatException: Failed to parse JSON string. Error: Type is not supported in /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Format/JSONFormatter.php:44
Stack trace:
#0 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Format/JSONFormatter.php(44): CodeIgniter\Format\Exceptions\FormatException::forInvalidJSON('Type is not sup...')
#1 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/API/ResponseTrait.php(345): CodeIgniter\Format\JSONFormatter->format(Array)
#2 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/API/ResponseTrait.php(98): CodeIgniter\Debug\ExceptionHandler->format(Array)
#3 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Debug/ExceptionHandler.php(81): CodeIgniter\Debug\ExceptionHandler->respond(Array, 500)
#4 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Debug/Exceptions.php(148): CodeIgniter\Debug\ExceptionHandler->handle(Object(PHPUnit\Event\Code\NoTestCaseObjectOnCallStackException), Object(CodeIgniter\HTTP\IncomingRequest), Object(CodeIgniter\HTTP\Response), 500, 1)
#5 [internal function]: CodeIgniter\Debug\Exceptions->exceptionHandler(Object(PHPUnit\Event\Code\NoTestCaseObjectOnCallStackException))
#6 {main}
  thrown in /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Format/JSONFormatter.php on line 44

ERRORS!
Tests: 27, Assertions: 45, Errors: 1.

kenjis · 2023-10-27T07:13:21Z

--- a/system/Format/JSONFormatter.php
+++ b/system/Format/JSONFormatter.php
@@ -37,6 +37,7 @@ class JSONFormatter implements FormatterInterface
 
         $options = ENVIRONMENT === 'production' ? $options : $options | JSON_PRETTY_PRINT;
 
+        log_message('debug', var_export($data, true));
         $result = json_encode($data, $options, 512);
 
         if (! in_array(json_last_error(), [JSON_ERROR_NONE, JSON_ERROR_RECURSION], true)) {

CRITICAL - 2023-10-27 07:08:34 --> Cannot find TestCase object on call stack
in VENDORPATH/phpunit/phpunit/src/Event/Value/Test/TestMethodBuilder.php on line 63.
 1 VENDORPATH/phpunit/phpunit/src/Runner/ErrorHandler.php(83): PHPUnit\Event\Code\TestMethodBuilder::fromCallStack()
 2 [internal function]: PHPUnit\Runner\ErrorHandler->__invoke(2, 'rewind(): Stream does not support seeking', 'Standard input code', 71)
 3 Standard input code(71): rewind(resource (stream))
 4 Standard input code(118): __phpunit_run_isolated_test()
DEBUG - 2023-10-27 07:08:34 --> array (
  'title' => 'PHPUnit\\Event\\Code\\NoTestCaseObjectOnCallStackException',
  'type' => 'PHPUnit\\Event\\Code\\NoTestCaseObjectOnCallStackException',
  'code' => 500,
  'message' => 'Cannot find TestCase object on call stack',
  'file' => '/Users/kenji/work/codeigniter/official/CodeIgniter4/vendor/phpunit/phpunit/src/Event/Value/Test/TestMethodBuilder.php',
  'line' => 63,
  'trace' => 
  array (
    0 => 
    array (
      'file' => '/Users/kenji/work/codeigniter/official/CodeIgniter4/vendor/phpunit/phpunit/src/Runner/ErrorHandler.php',
      'line' => 83,
      'function' => 'fromCallStack',
      'class' => 'PHPUnit\\Event\\Code\\TestMethodBuilder',
      'type' => '::',
      'args' => 
      array (
      ),
    ),
    1 => 
    array (
      'function' => '__invoke',
      'class' => 'PHPUnit\\Runner\\ErrorHandler',
      'type' => '->',
      'args' => 
      array (
        0 => 2,
        1 => 'rewind(): Stream does not support seeking',
        2 => 'Standard input code',
        3 => 71,
      ),
    ),
    2 => 
    array (
      'file' => 'Standard input code',
      'line' => 71,
      'function' => 'rewind',
      'args' => 
      array (
        0 => NULL,
      ),
    ),
    3 => 
    array (
      'file' => 'Standard input code',
      'line' => 118,
      'function' => '__phpunit_run_isolated_test',
      'args' => 
      array (
      ),
    ),
  ),
)
CRITICAL - 2023-10-27 07:08:34 --> Uncaught CodeIgniter\Format\Exceptions\FormatException: Failed to parse JSON string. Error: Type is not supported in /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Format/JSONFormatter.php:44
Stack trace:
#0 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Format/JSONFormatter.php(44): CodeIgniter\Format\Exceptions\FormatException::forInvalidJSON('Type is not sup...')
#1 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/API/ResponseTrait.php(345): CodeIgniter\Format\JSONFormatter->format(Array)
#2 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/API/ResponseTrait.php(98): CodeIgniter\Debug\ExceptionHandler->format(Array)
#3 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Debug/ExceptionHandler.php(81): CodeIgniter\Debug\ExceptionHandler->respond(Array, 500)
#4 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Debug/Exceptions.php(148): CodeIgniter\Debug\ExceptionHandler->handle(Object(PHPUnit\Event\Code\NoTestCaseObjectOnCallStackException), Object(CodeIgniter\HTTP\IncomingRequest), Object(CodeIgniter\HTTP\Response), 500, 1)
#5 [internal function]: CodeIgniter\Debug\Exceptions->exceptionHandler(Object(PHPUnit\Event\Code\NoTestCaseObjectOnCallStackException))
#6 {main}
  thrown
【Previous Exception】
PHPUnit\Event\Code\NoTestCaseObjectOnCallStackException
Cannot find TestCase object on call stack
#0 /Users/kenji/work/codeigniter/official/CodeIgniter4/vendor/phpunit/phpunit/src/Runner/ErrorHandler.php(83): PHPUnit\Event\Code\TestMethodBuilder::fromCallStack()
#1 [internal function]: PHPUnit\Runner\ErrorHandler->__invoke(2, 'rewind(): Strea...', 'Standard input ...', 71)
#2 Standard input code(71): rewind(Resource id #2)
#3 Standard input code(118): __phpunit_run_isolated_test()
#4 {main}
in SYSTEMPATH/Format/JSONFormatter.php on line 44.
 1 [internal function]: CodeIgniter\Debug\Exceptions->shutdownHandler()
DEBUG - 2023-10-27 07:08:34 --> array (
  'title' => 'ErrorException',
  'type' => 'ErrorException',
  'code' => 500,
  'message' => 'Uncaught CodeIgniter\\Format\\Exceptions\\FormatException: Failed to parse JSON string. Error: Type is not supported in /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Format/JSONFormatter.php:44
Stack trace:
#0 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Format/JSONFormatter.php(44): CodeIgniter\\Format\\Exceptions\\FormatException::forInvalidJSON(\'Type is not sup...\')
#1 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/API/ResponseTrait.php(345): CodeIgniter\\Format\\JSONFormatter->format(Array)
#2 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/API/ResponseTrait.php(98): CodeIgniter\\Debug\\ExceptionHandler->format(Array)
#3 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Debug/ExceptionHandler.php(81): CodeIgniter\\Debug\\ExceptionHandler->respond(Array, 500)
#4 /Users/kenji/work/codeigniter/official/CodeIgniter4/system/Debug/Exceptions.php(148): CodeIgniter\\Debug\\ExceptionHandler->handle(Object(PHPUnit\\Event\\Code\\NoTestCaseObjectOnCallStackException), Object(CodeIgniter\\HTTP\\IncomingRequest), Object(CodeIgniter\\HTTP\\Response), 500, 1)
#5 [internal function]: CodeIgniter\\Debug\\Exceptions->exceptionHandler(Object(PHPUnit\\Event\\Code\\NoTestCaseObjectOnCallStackException))
#6 {main}
  thrown
【Previous Exception】
PHPUnit\\Event\\Code\\NoTestCaseObjectOnCallStackException
Cannot find TestCase object on call stack
#0 /Users/kenji/work/codeigniter/official/CodeIgniter4/vendor/phpunit/phpunit/src/Runner/ErrorHandler.php(83): PHPUnit\\Event\\Code\\TestMethodBuilder::fromCallStack()
#1 [internal function]: PHPUnit\\Runner\\ErrorHandler->__invoke(2, \'rewind(): Strea...\', \'Standard input ...\', 71)
#2 Standard input code(71): rewind(Resource id #2)
#3 Standard input code(118): __phpunit_run_isolated_test()
#4 {main}',
  'file' => '/Users/kenji/work/codeigniter/official/CodeIgniter4/system/Format/JSONFormatter.php',
  'line' => 44,
  'trace' => 
  array (
    0 => 
    array (
      'function' => 'shutdownHandler',
      'class' => 'CodeIgniter\\Debug\\Exceptions',
      'type' => '->',
      'args' => 
      array (
      ),
    ),
  ),
)

kenjis · 2023-11-30T09:54:10Z

No good. Tests on PHP 8.3 fails.

There were 42 errors:

1) CodeIgniter\Autoloader\AutoloaderTest::testLoadHelpers
Test was run in child process and ended unexpectedly

2) CodeIgniter\CodeIgniterTest::testRunEmptyDefaultRoute
Test was run in child process and ended unexpectedly

3) CodeIgniter\CodeIgniterTest::testOutputBufferingControl
Test was run in child process and ended unexpectedly

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7043858533/job/19170759175?pr=8069

vendor/bin/phpunit --migrate-configuration -c phpunit.xml.dist

Message: file_put_contents(/home/runner/work/CodeIgniter4/CodeIgniter4/build/coverage/text/coverage.txt): Failed to open stream: No such file or directory Location: /home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/src/Runner/CodeCoverage.php:317 Script done. Error: Process completed with exit code 255.

1) CodeIgniter\Database\DatabaseTestCase\DatabaseTestCaseMigrationOnce1Test::testMigrationDone TypeError: json_encode(): Argument #2 ($flags) must be of type int, bool given /home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/Constraints/SeeInDatabase.php:118 /home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/DatabaseTestTrait.php:282 /home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Database/DatabaseTestCase/DatabaseTestCaseMigrationOnce1Test.php:86

There was 1 error: 1) CodeIgniter\Security\SecurityCSRFSessionRandomizeTokenTest::testCSRFVerifyPostInvalidToken PHPUnit\Framework\Exception: PHP Warning: hex2bin(): Hexadecimal input string must have an even length in /home/runner/work/CodeIgniter4/CodeIgniter4/system/Security/Security.php on line 378 PHP Warning: hex2bin(): Hexadecimal input string must have an even length in /home/runner/work/CodeIgniter4/CodeIgniter4/system/Security/Security.php on line 378

There was 1 error: 1) CodeIgniter\CommonFunctionsTest::testTraceWithCSP Test was run in child process and ended unexpectedly

…e.php

kenjis · 2024-04-07T03:38:46Z

Rebased to resolve the conflict.

MGatner · 2024-04-10T11:22:10Z

Happy to see this one launched!

kenjis · 2024-04-10T11:35:14Z

But we still need restore_error_handler() to separate process testing.
I don't know the true cause of the errors.

kenjis added the 4.5 label Oct 20, 2023

kenjis marked this pull request as draft October 20, 2023 23:57

kenjis force-pushed the update-phpunit-10 branch from 9a41574 to 54e6c4d Compare October 21, 2023 02:28

kenjis force-pushed the update-phpunit-10 branch from 9a6d208 to 7b1d446 Compare October 21, 2023 03:40

MGatner reviewed Oct 22, 2023

View reviewed changes

kenjis force-pushed the update-phpunit-10 branch 2 times, most recently from 2052f1a to a524abc Compare October 27, 2023 04:39

kenjis added the help wanted More help is needed for the proper resolution of an issue or pull request label Oct 27, 2023

github-actions bot added the stale Pull requests with conflicts label Oct 28, 2023

This comment was marked as outdated.

Sign in to view

kenjis force-pushed the update-phpunit-10 branch from a524abc to 2f23a6f Compare October 30, 2023 04:09

kenjis removed the stale Pull requests with conflicts label Oct 30, 2023

kenjis force-pushed the update-phpunit-10 branch from 2f23a6f to 69bcbbb Compare November 22, 2023 05:41

This comment was marked as outdated.

Sign in to view

github-actions bot added the stale Pull requests with conflicts label Nov 30, 2023

kenjis force-pushed the update-phpunit-10 branch from 69bcbbb to 1829df8 Compare November 30, 2023 08:26

kenjis removed the stale Pull requests with conflicts label Nov 30, 2023

kenjis force-pushed the update-phpunit-10 branch 2 times, most recently from 5b2f18f to 47bf62e Compare April 2, 2024 23:26

kenjis marked this pull request as ready for review April 2, 2024 23:45

kenjis changed the title ~~chore: update PHPUnit to 10~~ refactor: update PHPUnit to 10 Apr 2, 2024

kenjis force-pushed the update-phpunit-10 branch from 47bf62e to fe41852 Compare April 6, 2024 00:26

michalsn approved these changes Apr 6, 2024

View reviewed changes

samsonasik approved these changes Apr 6, 2024

View reviewed changes

kenjis added 17 commits April 7, 2024 12:38

chore: update PHPUnit to 10

fc989b1

test: rename abtract classname for PHPUnit10

041cd7a

chore: update phpunit.xml.dist for PHPUnit10

e360bed

vendor/bin/phpunit --migrate-configuration -c phpunit.xml.dist

chore: update gitignore for PHPUnit10

3434262

test: update PHPUnit error message for PHPUnit10

9568dc9

style: break long line

18d6a84

chore: update nexusphp/tachycardia

8b137fb

chore: change config section order

bec9e6d

test: workaround for errors on PHPUnit 10 and PHP 8.3

38d4aa7

test: workaround for errors on PHPUnit 10 and PHP 8.3

21e99b5

test: fix CommonFunctionsTest::testTraceWithCSP()

bf733f3

There was 1 error: 1) CodeIgniter\CommonFunctionsTest::testTraceWithCSP Test was run in child process and ended unexpectedly

test: add type definitions

625d42b

chore: vendor/bin/phpstan analyze --generate-baseline phpstan-baselin…

7fe8996

…e.php

chore: update PHPUnit version

9e009e9

kenjis force-pushed the update-phpunit-10 branch from fe41852 to 9e009e9 Compare April 7, 2024 03:38

kenjis merged commit 5c45ef1 into codeigniter4:4.5 Apr 7, 2024
38 checks passed

kenjis deleted the update-phpunit-10 branch April 7, 2024 03:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: update PHPUnit to 10 #8069

refactor: update PHPUnit to 10 #8069

kenjis commented Oct 20, 2023 •

edited

Loading

kenjis commented Oct 20, 2023

paulbalandan commented Oct 21, 2023

kenjis commented Oct 21, 2023

kenjis commented Oct 21, 2023

paulbalandan commented Oct 21, 2023

kenjis commented Oct 21, 2023

paulbalandan commented Oct 21, 2023

kenjis commented Oct 21, 2023

kenjis commented Oct 21, 2023

MGatner left a comment •

edited

Loading

paulbalandan commented Oct 26, 2023

kenjis commented Oct 27, 2023

kenjis commented Oct 27, 2023

This comment was marked as outdated.

This comment was marked as outdated.

kenjis commented Nov 30, 2023

kenjis commented Apr 7, 2024

MGatner commented Apr 10, 2024

kenjis commented Apr 10, 2024

refactor: update PHPUnit to 10 #8069

refactor: update PHPUnit to 10 #8069

Conversation

kenjis commented Oct 20, 2023 • edited Loading

kenjis commented Oct 20, 2023

paulbalandan commented Oct 21, 2023

kenjis commented Oct 21, 2023

kenjis commented Oct 21, 2023

paulbalandan commented Oct 21, 2023

kenjis commented Oct 21, 2023

paulbalandan commented Oct 21, 2023

kenjis commented Oct 21, 2023

kenjis commented Oct 21, 2023

MGatner left a comment • edited Loading

Choose a reason for hiding this comment

paulbalandan commented Oct 26, 2023

kenjis commented Oct 27, 2023

kenjis commented Oct 27, 2023

This comment was marked as outdated.

This comment was marked as outdated.

kenjis commented Nov 30, 2023

kenjis commented Apr 7, 2024

MGatner commented Apr 10, 2024

kenjis commented Apr 10, 2024

kenjis commented Oct 20, 2023 •

edited

Loading

MGatner left a comment •

edited

Loading