Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix types #8091

Merged
merged 4 commits into from
Oct 29, 2023
Merged

refactor: fix types #8091

merged 4 commits into from
Oct 29, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 25, 2023

Description

  • fix types for adding declare(strict_types=1)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Oct 25, 2023
@kenjis kenjis mentioned this pull request Oct 25, 2023
Merged
5 tasks
MGatner
MGatner reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to revisit this one, but I trust the pipeline would have caught any real issues.

@github-actions github-actions bot added the stale Pull requests with conflicts label Oct 27, 2023
@github-actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis removed the stale Pull requests with conflicts label Oct 27, 2023
MGatner
MGatner approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Aside gripe: it's pretty unfortunate that under strict types a Stringable can't be accepted as a string type without pre-casting. I feel like that was a missed opportunity in PHP.

@kenjis kenjis merged commit 40b31bc into codeigniter4:4.5 Oct 29, 2023
46 checks passed
@kenjis kenjis deleted the refactor-fix-types branch October 29, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.5 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner