fix: Hot reloading when session is enabled #8112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
added
the
bug
|
Hot reloading does not work. |
|
Thank you. I totally forgot about the |
lonnieezell
approved these changes
Oct 28, 2023
|
@michalsn I applied the patch, but the problem remained. The page cannot be updated $ patch -p1 < ~/Downloads/patch-diff.githubusercontent.com_raw_codeigniter4_CodeIgniter4_pull_8112.patch
patching file system/Debug/Toolbar/Views/toolbar.js
patching file system/HotReloader/HotReloader.php
patching file system/Debug/Toolbar/Views/toolbar.js
patching file system/Debug/Toolbar/Views/toolbar.tpl.php |
|
@neznaika0 Thank you for testing this out... unfortunately I have no other ideas for now. Although this PR fixes a valid bug. |
|
@michalsn Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we use the session globally, it can block other requests as they wait for the session to be available for writing. The hot reloader runs in the background as a "long-running process".
This PR may potentially fix: 8093
Checklist: