Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove traditional validation rule param types (2/2) #8124

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: remove traditional validation rule param types (2/2) #8124

merged 1 commit into from
Nov 3, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 30, 2023 •
edited
Loading

Description
Follow-up #8078

Type ?string still remains in system/Validation/Rules.php.
The differs and matches will be handled in #8122.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
refactor!: remove param types for traditional validation rules
8a3a9a0 
There is no guarantee that a string will be passed, so declaring strict types may result in a TypeError.
@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities 4.5 labels Oct 30, 2023
@kenjis kenjis mentioned this pull request Oct 30, 2023
Merged
5 tasks
@kenjis kenjis merged commit ea357ba into codeigniter4:4.5 Nov 3, 2023
45 checks passed
@kenjis kenjis deleted the fix-traditional-validation-rule-param-types-2 branch November 3, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn