Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Request::getEnv() deprecated #8234

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 20, 2023

Description
This method does not work from the beginning, and it was intentional.

    public function index(): string
    {
        dd($this->request->getEnv('CI_ENVIRONMENT'));
    }
$this->request->getEnv(...) null

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them refactor Pull requests that refactor code labels Nov 20, 2023
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
@kenjis kenjis merged commit cfc7ea7 into codeigniter4:develop Nov 22, 2023
@kenjis kenjis deleted the fix-request-getEnv branch November 22, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants