Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: autoload helpers in test bootstrap #8275

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: autoload helpers in test bootstrap #8275

merged 1 commit into from
Dec 2, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 29, 2023

Description
Fixes #8272

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 29, 2023
@kenjis kenjis mentioned this pull request Nov 29, 2023
Closed
datamweb
datamweb reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matter surprised me a few days ago.
https://github.com/lonnieezell/forum-example/actions/runs/7001465674/job/19043601740

@kenjis
Copy link
Member Author

kenjis commented Nov 29, 2023 •
edited
Loading

Oh, I didn't notice it because the tests in the PR passed.

@kenjis kenjis merged commit 0c9b3ff into codeigniter4:develop Dec 2, 2023
61 checks passed
@kenjis kenjis deleted the fix-test-autoload-helpers branch December 2, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb left review comments

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: autoloader: global helpers are not loaded when bootstraped with phpunit
4 participants
@kenjis @michalsn @datamweb @MGatner