Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: HTTP verbs in Router #8317

Merged
merged 5 commits into from
Dec 11, 2023
Merged

refactor: HTTP verbs in Router #8317

merged 5 commits into from
Dec 11, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 10, 2023 •
edited
Loading

Description
Follow-up #8235

  • refactor AutoRouter and AutoRouterImproved (They are final classes, so these changes are not breaking changes.)
  • use HTTP\Method in tests

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Dec 10, 2023
@kenjis kenjis merged commit bc97a0e into codeigniter4:4.5 Dec 11, 2023
45 checks passed
@kenjis kenjis deleted the refactor-HTTP-verb-in-routes branch December 11, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn