Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Auto Routing Improved] spark routes shows incorrect routes when translateURIDashes is enabled #8320

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 10, 2023

Description
Follow-up #7422

Before:

+-----------+-----------------+------+--------------------------------------+----------------+---------------+
| Method    | Route           | Name | Handler                              | Before Filters | After Filters |
+-----------+-----------------+------+--------------------------------------+----------------+---------------+
| GET(auto) | foo_bar/foo_bar |      | \App\Controllers\Foo_bar::getFoo_bar |                | toolbar       |
+-----------+-----------------+------+--------------------------------------+----------------+---------------+

After:

+-----------+-----------------+------+--------------------------------------+----------------+---------------+
| Method    | Route           | Name | Handler                              | Before Filters | After Filters |
+-----------+-----------------+------+--------------------------------------+----------------+---------------+
| GET(auto) | foo-bar/foo-bar |      | \App\Controllers\Foo_bar::getFoo_bar |                | toolbar       |
+-----------+-----------------+------+--------------------------------------+----------------+---------------+

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 10, 2023
@kenjis kenjis merged commit 8f2c065 into codeigniter4:develop Dec 11, 2023
61 checks passed
@kenjis kenjis deleted the fix-spark-routes-auto-routing-translateURIDashes branch December 11, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants