Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return a new instance of a Cell #8330

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

michalsn
Copy link
Member

Description
This PR introduces a change in how we load Cells. Right now we can return either a new instance when we use the full namespace or a shared one when we don't use the FQCN.

This may lead to many problems. This change seems to mitigate all the issues. Also returning a new instance class for every Cell call seems right.

Supersedes #8327
Fixes #8326

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 14, 2023
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably there will be almost no cases where the Cell object must be shared, so this seems to be fine.

@michalsn michalsn merged commit fc17a53 into codeigniter4:develop Dec 15, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: View Cell Inheritance Issue in Placeholder Values
3 participants