Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: apply DisallowedEmptyRuleFixerRector #8344

Merged
merged 15 commits into from
Dec 21, 2023
Merged

refactor: apply DisallowedEmptyRuleFixerRector #8344

merged 15 commits into from
Dec 21, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 18, 2023 •
edited
Loading

Needs #8341

Description

  • replace empty()
  • add and apply
    • TernaryEmptyArrayArrayDimFetchToCoalesceRector
    • EmptyOnNullableObjectToInstanceOfRector
    • DisallowedEmptyRuleFixerRector

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Dec 18, 2023
@kenjis kenjis marked this pull request as draft December 18, 2023 00:34
@kenjis kenjis mentioned this pull request Dec 18, 2023
Merged
5 tasks
@kenjis kenjis force-pushed the add-DisallowedEmptyRuleFixerRector branch from b762124 to e6fca6e Compare December 19, 2023 02:38
@kenjis kenjis marked this pull request as ready for review December 19, 2023 02:39
paulbalandan
paulbalandan reviewed Dec 20, 2023
View reviewed changes
system/Common.php Show resolved Hide resolved
system/Test/FeatureTestCase.php Outdated Show resolved Hide resolved
@kenjis kenjis force-pushed the add-DisallowedEmptyRuleFixerRector branch from e6fca6e to e8980a8 Compare December 21, 2023 00:47
@kenjis kenjis force-pushed the add-DisallowedEmptyRuleFixerRector branch from 2f19793 to 64866aa Compare December 21, 2023 01:10
paulbalandan
paulbalandan reviewed Dec 21, 2023
View reviewed changes
system/Common.php Outdated Show resolved Hide resolved
@kenjis kenjis merged commit c0c5fca into codeigniter4:develop Dec 21, 2023
61 checks passed
@kenjis kenjis deleted the add-DisallowedEmptyRuleFixerRector branch December 21, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @paulbalandan