Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in pager default_simple #8407

Merged
merged 1 commit into from
Jan 7, 2024
Merged

fix: typo in pager default_simple #8407

merged 1 commit into from
Jan 7, 2024

Conversation

jasonliang-dev
Copy link
Contributor

@jasonliang-dev jasonliang-dev commented Jan 7, 2024 •
edited
Loading

Description
getnext -> getNext

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
Copy link
Member

michalsn commented Jan 7, 2024

Can you run:

vendor/bin/phpstan analyse --generate-baseline phpstan-baseline.php

to fix the PHPStan error?

michalsn
michalsn approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@samsonasik samsonasik merged commit bbd4f1b into codeigniter4:develop Jan 7, 2024
60 of 62 checks passed
@samsonasik
Copy link
Member

Thank you @jasonliang-dev

@kenjis kenjis added the refactor Pull requests that refactor code label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonliang-dev @michalsn @samsonasik @kenjis