Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve Forge variable names #8434

Merged
merged 22 commits into from
Jan 20, 2024
Merged

refactor: improve Forge variable names #8434

merged 22 commits into from
Jan 20, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 19, 2024 •
edited
Loading

Description

  • rename variable names

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jan 19, 2024
@kenjis kenjis marked this pull request as draft January 19, 2024 06:27
@kenjis
docs: add PHPDocs
c452ad0
@kenjis
style: break long line
add3e07
@kenjis
refactor: rename variable names
4ac6ca5 
Variables with the same meaning have the same variable name.
Variables with different meanings are given different names.
@kenjis kenjis marked this pull request as ready for review January 19, 2024 07:41
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Jan 20, 2024
@kenjis kenjis merged commit 28cf32b into codeigniter4:develop Jan 20, 2024
62 checks passed
@kenjis kenjis deleted the refactor-Forge-variables branch January 20, 2024 22:11
@kenjis
Copy link
Member Author

kenjis commented Jan 20, 2024

@michalsn Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
database Issues or pull requests that affect the database layer refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn