Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Postgre] QueryBuilder::deleteBatch() does not work #8451

Merged
merged 4 commits into from
Jan 25, 2024
Merged

fix: [Postgre] QueryBuilder::deleteBatch() does not work #8451

merged 4 commits into from
Jan 25, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 25, 2024

Description

  • fix type error in deleteBatch() on PostgreSQL

Ref #8439

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jan 25, 2024
@kenjis kenjis mentioned this pull request Jan 25, 2024
Merged
5 tasks
sclubricants
sclubricants reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@sclubricants sclubricants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think upsertBatch() should be ok because it uses VALUES()

@kenjis kenjis merged commit 5fd5f63 into codeigniter4:develop Jan 25, 2024
62 checks passed
@kenjis kenjis deleted the fix-postgre-deleteBatch branch January 25, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sclubricants sclubricants sclubricants approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @sclubricants