feat: [Model] add option $updateOnlyChanged #8455
Conversation
kenjis
force-pushed
the
feat-Model-updateOnlyChanged
branch
from
c999761
to
cbee64b
Compare
| @@ -17,6 +17,8 @@ class {class} extends Model | |||
| protected $protectFields = true; | |||
| protected $allowedFields = []; | |||
|
|
|||
| protected bool $updateOnlyChanged = true; | |||
There was a problem hiding this comment.
Maybe for better usability, we should default this to false?
There was a problem hiding this comment.
I think the default to false is better.
So if we agree, I will change it.
It changes the update behavior, but existing apps do not seem to break.
So it is not a breaking change?
There was a problem hiding this comment.
I don't believe it would have side effects on existing apps. We should mention this change but not under "breaking changes".
+1 for false
There was a problem hiding this comment.
Since it's only for new models generated I wouldn't consider it a breaking change of any sort. Agree with @michalsn that maybe mention it, but not under breaking changes.
There was a problem hiding this comment.
Oh, you mean only change the value in the make:model template.
I thought you meant both BaseModel and the template.
Isn't it confusing to change only the template?
kenjis
added
the
docs needed
|
👋 Hi, @kenjis! |
kenjis
force-pushed
the
feat-Model-updateOnlyChanged
branch
from
cbee64b
to
136d48e
Compare
kenjis
added
database
kenjis
force-pushed
the
feat-Model-updateOnlyChanged
branch
from
136d48e
to
6a5ca0b
Compare
kenjis
removed
the
docs needed
|
Added changelog. The value in |
Description
See https://forum.codeigniter.com/showthread.php?tid=87742
Checklist: