New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor ImageMagickHandlerTest #8461

Merged

paulbalandan merged 1 commit into codeigniter4:develop from paulbalandan:imagick-convert

Jan 27, 2024

Member

paulbalandan commented Jan 26, 2024

Description
This refactors the test to:

check all available sources of the convert program
move the extension_loaded check to the native PHPUnit annotation
fail gracefully and skip the tests altogether if convert is missing instead of erroring midway through the test, i.e. Esh: /usr/local/bin/convert: No such file or directory

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide


          test: refactor ImageMagickHandlerTest

cc0e21f

kenjis added the testing label

kenjis approved these changes

View reviewed changes

paulbalandan merged commit 3734bbb into codeigniter4:develop

59 checks passed

paulbalandan deleted the imagick-convert branch

January 27, 2024 17:52

kenjis added the refactor label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor testing