feat: 404 controller also can get PageNotFoundException message #8491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
approved these changes
Feb 1, 2024
datamweb
reviewed
Feb 1, 2024
tests/_support/Errors.php
Outdated
|
|
||
| class Errors extends Controller | ||
| { | ||
| public function show404(string $message) |
There was a problem hiding this comment.
Suggested change
| public function show404(string $message) | |
| public function show404(string $message): string |
kenjis
force-pushed
the
feat-404-controller-gets-exception-message
branch
from
867f6c1
to
33c241c
Compare
|
Added changelog. |
kenjis
force-pushed
the
feat-404-controller-gets-exception-message
branch
from
33c241c
to
ff3a05a
Compare
kenjis
force-pushed
the
feat-404-controller-gets-exception-message
branch
from
ff3a05a
to
8c09f34
Compare
crustamet
approved these changes
Feb 4, 2024
datamweb
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #8485
In the current implementation, 404 closure can get the PageNotFoundException message as a parameter,
but 404 controller can't.
This PR enables 404 controller to get the messsage as the first parameter.
Checklist: