Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add event points for spark commands #8496

Merged
merged 4 commits into from
Feb 4, 2024
Merged

feat: add event points for spark commands #8496

merged 4 commits into from
Feb 4, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 1, 2024 •
edited
Loading

Description
Closes #8442

  • add event points pre_command and post_command

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Feb 1, 2024
@kenjis kenjis mentioned this pull request Feb 1, 2024
Closed
Martin-4Spaces
Martin-4Spaces approved these changes Feb 1, 2024
View reviewed changes
Copy link

@Martin-4Spaces Martin-4Spaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I can also confirm that, it will trigger events if one would use the command helper to launch a command from Web application.

@kenjis kenjis changed the title feat: add event points for spark feat: add event points for spark commands Feb 1, 2024
@kenjis
Copy link
Member Author

kenjis commented Feb 2, 2024

Added changelog.

@kenjis kenjis merged commit 75b5701 into codeigniter4:4.5 Feb 4, 2024
47 checks passed
@kenjis kenjis deleted the feat-spark-events branch February 4, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

@Martin-4Spaces Martin-4Spaces Martin-4Spaces approved these changes

Assignees
No one assigned
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kenjis @lonnieezell @michalsn @datamweb @Martin-4Spaces