Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.5] refactor: add declare(strict_types=1) to ForgeModifyColumnTest #8502

Merged
merged 1 commit into from
Feb 4, 2024
Merged

[4.5] refactor: add declare(strict_types=1) to ForgeModifyColumnTest #8502

merged 1 commit into from
Feb 4, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 2, 2024

Description

  • add missing declare(strict_types=1)

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Feb 2, 2024
@kenjis
Copy link
Member Author

kenjis commented Feb 4, 2024

Can someone approve?

samsonasik
samsonasik approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a test file, so it should be safe 👍

@kenjis kenjis merged commit d4362c4 into codeigniter4:4.5 Feb 4, 2024
43 checks passed
@kenjis kenjis deleted the add-strict-types-ForgeModifyColumnTest branch February 4, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
4.5 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik