Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.5] fix: DEBUG-VIEW comments are not output #8523

Merged
merged 2 commits into from
Feb 10, 2024
Merged

[4.5] fix: DEBUG-VIEW comments are not output #8523

merged 2 commits into from
Feb 10, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 7, 2024 •
edited
Loading

Description
Follow-up #8053

Fix a bug that DEBUG-VIEW comments are not output.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.5 labels Feb 7, 2024
@kenjis kenjis force-pushed the fix-debugbar-View-DEBUG-VIEW branch from 92a3405 to 72240a7 Compare February 7, 2024 01:17
@kenjis kenjis changed the title fix: DEBUG-VIEW comments are not output [4.5] fix: DEBUG-VIEW comments are not output Feb 7, 2024
@kenjis kenjis merged commit 32df1ab into codeigniter4:4.5 Feb 10, 2024
46 checks passed
@kenjis kenjis deleted the fix-debugbar-View-DEBUG-VIEW branch February 10, 2024 00:20
@kenjis
Copy link
Member Author

kenjis commented Feb 10, 2024

@michalsn Thank you for reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn