Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: permit __invoke() method as Controller default method #8533

Merged
merged 3 commits into from
Feb 17, 2024
Merged

feat: permit __invoke() method as Controller default method #8533

merged 3 commits into from
Feb 17, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 10, 2024 •
edited
Loading

Description

  • permit __invoke() method as Controller default method

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Feb 10, 2024
@kenjis kenjis force-pushed the feat-permit-controller-invoke branch 2 times, most recently from aa7475b to 16c688a Compare February 11, 2024 00:51
@kenjis kenjis marked this pull request as draft February 11, 2024 02:14
@kenjis kenjis marked this pull request as ready for review February 11, 2024 04:24
michalsn
michalsn approved these changes Feb 11, 2024
View reviewed changes
user_guide_src/source/incoming/routing.rst Outdated Show resolved Hide resolved
@codeigniter4 codeigniter4 deleted a comment from vini123 Feb 11, 2024
@kenjis kenjis force-pushed the feat-permit-controller-invoke branch from 16c688a to 70094cb Compare February 11, 2024 23:40
@kenjis @michalsn
docs: fix by proofreading
e2ae3ef 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@kenjis kenjis requested a review from MGatner February 13, 2024 01:41
@kenjis kenjis merged commit 6614567 into codeigniter4:4.5 Feb 17, 2024
47 checks passed
@kenjis kenjis deleted the feat-permit-controller-invoke branch February 17, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

@MGatner MGatner Awaiting requested review from MGatner

Assignees
No one assigned
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb