Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: apply early return pattern #8621

Merged
merged 2 commits into from
Mar 15, 2024
Merged

refactor: apply early return pattern #8621

merged 2 commits into from
Mar 15, 2024

Conversation

justbyitself
Copy link
Contributor

@justbyitself justbyitself commented Mar 12, 2024 •
edited by kenjis
Loading

Apply early return (or return early) pattern.
It's more readable and a bit shorter

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the refactor Pull requests that refactor code label Mar 13, 2024
@ddevsr ddevsr requested a review from kenjis March 13, 2024 04:11
MGatner
MGatner approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MGatner MGatner merged commit aeafd03 into codeigniter4:develop Mar 15, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@datamweb datamweb datamweb approved these changes

@MGatner MGatner MGatner approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justbyitself @kenjis @datamweb @MGatner @ddevsr