Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: followup performance service() #8623

Merged
merged 1 commit into from
Mar 16, 2024
Merged

refactor: followup performance service() #8623

merged 1 commit into from
Mar 16, 2024

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Mar 14, 2024 •
edited by kenjis
Loading

Description
Follow-up #8607

Why not use service() after improvement.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added 4.5 refactor Pull requests that refactor code labels Mar 14, 2024
kenjis
kenjis approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 3e9a9c9 into codeigniter4:4.5 Mar 16, 2024
46 checks passed
@kenjis
Copy link
Member

kenjis commented Mar 16, 2024

@ddevsr Thank you!

@ddevsr ddevsr deleted the use-services branch March 17, 2024 00:14
@kenjis kenjis mentioned this pull request Aug 18, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
4.5 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddevsr @kenjis