Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Time::difference() DST bug #8661

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 26, 2024

Description
Supersedes #8659
See https://forum.codeigniter.com/showthread.php?tid=90472

Fixed to not convert to UTC when the two time zones are the same.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities docs needed Pull requests needing documentation write-ups and/or revisions. labels Mar 26, 2024
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Mar 27, 2024
@kenjis
Copy link
Member Author

kenjis commented Mar 27, 2024

Added docs.

@kenjis kenjis merged commit 8e64913 into codeigniter4:develop Mar 29, 2024
57 checks passed
@kenjis kenjis deleted the fix-time-diff-DST branch March 29, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants