Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Model::set() does not accept object #8670

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 28, 2024

Description
See https://forum.codeigniter.com/showthread.php?tid=90502

When you need a more flexible solution, you can leave the parameters empty and it functions like the Query Builder’s update command, with the added benefit of validation, events, etc:
https://codeigniter4.github.io/CodeIgniter4/models/model.html#update

So, Model::set() should accept object or Entity.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Mar 28, 2024
@kenjis kenjis merged commit 404e50b into codeigniter4:develop Mar 29, 2024
56 checks passed
@kenjis kenjis deleted the fix-model-set-entity branch March 29, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants