Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify ImageMagickHandler::getVersion() #8681

Merged
merged 1 commit into from
Mar 30, 2024
Merged

refactor: simplify ImageMagickHandler::getVersion() #8681

merged 1 commit into from
Mar 30, 2024

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Mar 29, 2024 •
edited
Loading

Description
Refactoring to use one preg_match call instead of preg_match then str_replace.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Mar 30, 2024
kenjis
kenjis approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulbalandan paulbalandan merged commit 7ca24b2 into codeigniter4:develop Mar 30, 2024
56 checks passed
@paulbalandan paulbalandan deleted the imagemagick-getversion branch March 30, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @kenjis