Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.5] fix: TypeError in Filters #8683

Merged
merged 3 commits into from
Mar 30, 2024
Merged

[4.5] fix: TypeError in Filters #8683

merged 3 commits into from
Mar 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 30, 2024 •
edited
Loading

Description

  • fix TypeError
  • update test code

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis
fix: TypeError in Filters
492425a 
TypeError: urldecode(): Argument #1 ($string) must be of type string, null given
@kenjis
test: update FiltersTest assertion
f7c46dd
@kenjis
test: update ConfigCheckTest assertions
cceb1e8
@kenjis kenjis changed the title fix: TypeError in Filters [4.5] fix: TypeError in Filters Mar 30, 2024
@kenjis kenjis added 4.5 bug Verified issues on the current code behavior or pull requests that will fix them labels Mar 30, 2024
@kenjis kenjis merged commit ee8e117 into codeigniter4:4.5 Mar 30, 2024
38 of 40 checks passed
@kenjis kenjis deleted the fix-Filters-4.5 branch March 30, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.5 bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan