refactor: DB config properties #8693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the values for MySQLi.
This property is only for MySQL, and there does not appear to be any other databases that will require this property in the future. So it should be in MySQLi\Connection.
kenjis
added
database
michalsn
approved these changes
Apr 2, 2024
michalsn
reviewed
Apr 2, 2024
| // 'time' => 'H:i:s', | ||
| // ], | ||
| // ]; | ||
|
|
There was a problem hiding this comment.
Do we really want to include all these examples here, and not in the user guide? I understand that it can be handy, but in general, I don't think we include examples in the code we distribute.
There was a problem hiding this comment.
The existence of these examples makes it take less time to set up. I have no problem with these.
There was a problem hiding this comment.
If we change the default DB driver, we would edit this file.
So they make it take less time to set up than the user guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: